RFR: 8341052: SHA-512 implementation using SHA-NI [v3]
Srinivas Vamsi Parasa
duke at openjdk.org
Thu Oct 10 23:04:10 UTC 2024
On Wed, 9 Oct 2024 18:31:41 GMT, Smita Kamath <svkamath at openjdk.org> wrote:
>> Hi, I want to submit an optimization for SHA-512 algorithm using SHA instructions (sha512msg1, sha512msg2 and sha512rnds2) . Kindly review the code and provide feedback. Thank you.
>
> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressed a review comment
This implementation looks good to me.
I went through the implementation of `sha512_update_ni_x1`. Looked at it line by line and compared it to the ipsec [implementation](https://github.com/intel/intel-ipsec-mb/blob/main/lib/avx2_t4/sha512_x1_ni_avx2.asm).
Thanks,
Srinivas Vamsi Parasa (Intel)
-------------
Marked as reviewed by vamsi-parasa at github.com (no known OpenJDK username).
PR Review: https://git.openjdk.org/jdk/pull/20633#pullrequestreview-2361568171
More information about the hotspot-compiler-dev
mailing list