RFR: 8340141: C1: rework ciMethod::equals following 8338471 [v3]

[Dean Long]

On Thu, 10 Oct 2024 22:40:44 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This PR changes ciMethod::equals() to a special-purpose debug helper method for the one place in C1 that uses it in an assert.  The reason why making it general purpose is difficult is because JVMTI can add and delete methods.   See the bug report and JDK-8338471 for more details.  I'm open to suggestions for a better name than equals_ignore_version().
>> 
>> An alternative approach, which I think may actually be better, would be to check for old methods first, and bail out if we see any.  Then we can change the assert back to how it was originally, using ==.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make sure to be in VM state when checking is_old

Hold off on re-reviews.  I need to fix some errors introduced by moving the VM state transitions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21148#issuecomment-2406329451