RFR: 8341781: Improve Min/Max node identities [v2]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Fri Oct 11 15:15:55 UTC 2024


On Fri, 11 Oct 2024 07:03:44 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> On closer inspection it seems that because of the CMove cost model, the outer min/max operation doesn't get turned into a CMove so the Long IR rules don't reliably get matched anywhere. It must have slipped through the cracks because of the way that my IR rules were structured, I only realized this after I added the compile phase to the other 2 rules. I think for this to work it would need the intrinsics from the other PR. Do you think we should continue with this PR with the Long cases disabled and enable it afterwards, or should we wait for #20098 to be merged?
>
> Thanks for sharing more details. I think it's perfectly fine to still add them now but leave them disabled with a reference to JDK-8307513 since you already wrote them.

Sounds good!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21439#discussion_r1797098107


More information about the hotspot-compiler-dev mailing list