RFR: 8341831: PhaseCFG::insert_anti_dependences asserts with "no loads" [v3]

[Igor Veresov]

On Fri, 11 Oct 2024 19:09:06 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> src/hotspot/share/opto/gcm.cpp line 773:
> 
>> 771:     if (use_mem_state->is_Mach()) {
>> 772:       int ideal_op = use_mem_state->as_Mach()->ideal_Opcode();
>> 773:       is_cache_wb = (ideal_op == Op_CacheWB || ideal_op == Op_CacheWBPostSync || ideal_op == Op_CacheWBPreSync);
> 
> The match rules for CacheWBPostSync and CacheWBPreSync don't have memory operands.  Is needs_anti_dependence_check() really returning true for them?

Yes, you're right. I'll remove those.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21455#discussion_r1797399651