RFR: 8341622: Tag-specific disabled default decorators for UnifiedLogging [v6]

Antón Seoane duke at openjdk.org
Mon Oct 14 11:25:20 UTC 2024


On Wed, 9 Oct 2024 09:13:37 GMT, Antón Seoane <duke at openjdk.org> wrote:

>> Currently, the Unified Logging framework defaults to three decorators (uptime, level, tags) whenever the user does not specify otherwise through -Xlog. However, some specific logging cases do not need decorations, and manually having to disable them results in cumbersome extra input and loss of ergonomics. For example, C2 developers rarely need decorations, and having to manually specify this every time results inconvenient.
>> 
>> To address this, this PR enables the possibility of adding tag-specific disabling of default decorators to UL. These disables are in no way overriding user input -- they will only act whenever -Xlog has no decorators supplied and there is a positive match with the pre-specified defaults. Such a match is based on an inclusion rule: e.g. if -Xlog:jit+compilation is provided, a default for jit may be applied. Additionally, defaults may target a specific log level.
>> 
>> The original use case for this is related to C2 logging migration to UnifiedLogging, as currently no decorators are found in compiler logs and it would be expected to stay the same without the extra explicit removal every time via -Xlog. However, this would ease the migration of other logging that was initially deterred by this, such as -XX:+PrintInterpreter.
>> 
>> This PR is a simplification of the [8340363](https://bugs.openjdk.org/browse/JDK-8340363) (closed) ticket.
>
> Antón Seoane has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace LogDecorators::Decorator::NoDecorator with LogDecorators::None

Right now, no space is being added at the beginning. I agree that it should be important to at least distinguish decorators from the message itself and I hope to address that, alongside multiline/grouping, in a future PR (adding a space between them seems an easy and sensible choice IMO, and in the case for no decorators we would just have a starting space which does not affect human readability).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21383#issuecomment-2410918753


More information about the hotspot-compiler-dev mailing list