RFR: 8339067: Convert Threshold flags (like Tier4MinInvocationThreshold and Tier3MinInvocationThreshold) to double [v2]

[Emanuel Peter]

On Tue, 15 Oct 2024 06:42:51 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This is trivial PR to change data type of some "*Threshold" variables form `intx` to `double`.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updates tier2 threshold datatype

Instead of changing the `product` flags (is a CSR needed for that?), you could also just cast to `double` at every use site. Would that also work?

src/hotspot/share/opto/bytecodeInfo.cpp line 316:

> 314:       int call_site_count  = caller_method->scale_count(profile.count());
> 315:       int invoke_count     = caller_method->interpreter_invocation_count();
> 316:       assert(invoke_count >= 0, "require invocation count greater than zero");

Technically, the comment is now wrong. It is no longer "greater than" but "greater than or equal to zero". Is that intended? Otherwise you should use `>`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21354#issuecomment-2414437954
PR Review Comment: https://git.openjdk.org/jdk/pull/21354#discussion_r1801504146