RFR: 8338126 : C2 SuperWord: VectorCastF2HF / vcvtps2ph produces wrong results for vector length 2 [v2]

Jatin Bhateja jbhateja at openjdk.org
Wed Oct 16 02:25:11 UTC 2024


On Wed, 16 Oct 2024 01:35:48 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorization/TestFloatConversionsVector.java line 110:
>> 
>>> 108:         }
>>> 109: 
>>> 110:         // Verifying the result
>> 
>> Since we are using IR framework, we can leverage existing[ @Check](https://github.com/openjdk/jdk/blob/521effe017b9b6322036f1851220056a637d6b1c/test/hotspot/jtreg/compiler/lib/ir_framework/Check.java#L32) annotation for verification which works in conjunction with @Test method, it will automatically invoke validation after test method execution. We may need little refactoring for this.
>
> The added test follows the verification mechanism used already in the test. I would prefer not to get into refactoring.

Okay, we can do it separately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21480#discussion_r1802242680


More information about the hotspot-compiler-dev mailing list