RFR: 8342042: PPC64: compiler_fast_unlock_object flags failure instead of success
Richard Reingruber
rrich at openjdk.org
Wed Oct 16 07:58:09 UTC 2024
On Wed, 16 Oct 2024 07:39:09 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> Seems like `compiler_fast_unlock_lightweight_object` could do the same.
>
> It does the same branch, but correctly, by going through a `crorc(CCR0, Assembler::equal, CCR0, Assembler::equal)` in the success path.
I think you're right. I wanted to see if [`set_eq_unlocked`](https://github.com/openjdk/jdk/blob/dcac4b0a532f2ca6cb374da7ece331e8266ab351/src/hotspot/cpu/ppc/macroAssembler_ppc.cpp#L3087) could be eliminated and then forgot about it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21496#issuecomment-2416001910
More information about the hotspot-compiler-dev
mailing list