RFR: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR

Matthias Baesken mbaesken at openjdk.org
Wed Oct 16 13:54:12 UTC 2024


On Mon, 14 Oct 2024 13:51:21 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> Make sure `LIR_Assembler::emit_unwind_handler()` jumps to the slow path directly for unlocking a synchronized method if `LM_MONITOR` is used.
> On the fast paths assertions are added that the mode is actually handled.
> 
> The change passed our CI testing:
> Tier 1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
> Testing was done on the main platforms and also on Linux/PPC64le and AIX.

Marked as reviewed by mbaesken (Reviewer).

Do you think
src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp 

`LIR_Assembler::emit_unwind_handler() `

should be adjusted in a similar way (separate issue/change however).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21497#pullrequestreview-2372556029
PR Comment: https://git.openjdk.org/jdk/pull/21497#issuecomment-2416912098


More information about the hotspot-compiler-dev mailing list