RFR: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions [v2]

[hanklo6]

On Wed, 9 Oct 2024 22:14:29 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> hanklo6 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add copyright header
>
> test/hotspot/gtest/x86/test_assemblerx86.cpp line 26:
> 
>> 24: #include "precompiled.hpp"
>> 25: 
>> 26: #if defined(X86)
> 
> You may add ` && !defined(ZERO)` similar to `test_assembler_aarch64.cpp` test.

Thanks, done.

> test/hotspot/gtest/x86/test_assemblerx86.cpp line 93:
> 
>> 91:   address entry = __ pc();
>> 92: 
>> 93:   // python x86-asmtest.py | expand > asmtest.out.h
> 
> The PR description shows different instructions to build:
> 
> With binutils = 2.43
> python3 x86-asmtest.py > asmtest.out.h
> 
> 
> I would like to have comment with correct and detailed instructions how to build `asmtest.out.h`

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20857#discussion_r1803755497
PR Review Comment: https://git.openjdk.org/jdk/pull/20857#discussion_r1803755724