RFR: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions [v4]
Vladimir Kozlov
kvn at openjdk.org
Wed Oct 16 23:53:15 UTC 2024
On Wed, 16 Oct 2024 21:13:57 GMT, hanklo6 <duke at openjdk.org> wrote:
>> Add test generation tool and gtest for testing APX encoding of instructions with extended general-purpose registers.
>>
>> Intel Advanced Performance Extensions (APX) doubles the number of general-purpose registers, from 16 to 32. For more information about APX, see https://www.intel.com/content/www/us/en/developer/articles/technical/advanced-performance-extensions-apx.html.
>>
>> By specification, instruction encoding remains unchanged for instructions using only the lower 16 GPRs. For cases where one or more instruction operands reference extended GPRs (Egprs), encoding targets either REX2, an extension of REX encoding, or an extended version of EVEX encoding. These new encoding schemes extend or modify existing instruction prefixes only when Egprs are used.
>>
>> ### Generate test instructions
>> With `binutils = 2.43`
>> * `python3 x86-asmtest.py > asmtest.out.h`
>> ### Run test
>> * `make test TEST="gtest:AssemblerX86"`
>
> hanklo6 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into apx-test-tool
> - Add comment and defined
> - Add copyright header
> - Remove tab
> - Remove whitespace
> - Replace whitespace with tab
> - Add flag before testing
> - Fix assertion error on MacOS
> - Add _LP64 flag
> - Add missing header
> - ... and 6 more: https://git.openjdk.org/jdk/compare/1ffcb678...ca48f240
Looks good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20857#pullrequestreview-2373870962
More information about the hotspot-compiler-dev
mailing list