RFR: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions [v4]

Jatin Bhateja jbhateja at openjdk.org
Thu Oct 17 02:41:21 UTC 2024


On Thu, 17 Oct 2024 02:06:05 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> hanklo6 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into apx-test-tool
>>  - Add comment and defined
>>  - Add copyright header
>>  - Remove tab
>>  - Remove whitespace
>>  - Replace whitespace with tab
>>  - Add flag before testing
>>  - Fix assertion error on MacOS
>>  - Add _LP64 flag
>>  - Add missing header
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/8405335e...ca48f240
>
> test/hotspot/gtest/x86/x86-asmtest.py line 655:
> 
>> 653: }
>> 654: 
>> 655: for RegOp, ops in instruction_set.items():
> 
> Rest of the code is modular, can you kindly refactor following code into a top level routine called from __main__ method.

Binutils toolset is specfic for linux. Please add 
relevant OS.name check and exit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20857#discussion_r1804009409


More information about the hotspot-compiler-dev mailing list