Integrated: 8342042: PPC64: compiler_fast_unlock_object flags failure instead of success

Richard Reingruber rrich at openjdk.org
Thu Oct 17 07:22:19 UTC 2024


On Mon, 14 Oct 2024 13:29:43 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This change inverts the `EQ` bit in `flag` with a condition register nand instruction in order to meet the post condition given at L2751-L2752:
> 
> 
>   // flag == EQ indicates success, decrement held monitor count
>   // flag == NE indicates failure
> 
> 
> The fix passed our CI testing with LockingMode set to LM_LEGACY
> Tier1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
> Testing was done on the main platforms and also on Linux/PPC64le and AIX.
> 
> The test runtime/logging/MonitorInflationTest.java failed on all platforms. Apparently it has issues with LM_LEGACY.

This pull request has now been integrated.

Changeset: fa39e84d
Author:    Richard Reingruber <rrich at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fa39e84d64d79f6c66f98110e98d2562f35681e1
Stats:     16 lines in 1 file changed: 4 ins; 8 del; 4 mod

8342042: PPC64: compiler_fast_unlock_object flags failure instead of success

Reviewed-by: mdoerr, aboldtch, fbredberg

-------------

PR: https://git.openjdk.org/jdk/pull/21496


More information about the hotspot-compiler-dev mailing list