Integrated: 8341622: Tag-specific disabled default decorators for UnifiedLogging
Antón Seoane
duke at openjdk.org
Thu Oct 17 09:21:27 UTC 2024
On Mon, 7 Oct 2024 08:56:40 GMT, Antón Seoane <duke at openjdk.org> wrote:
> Currently, the Unified Logging framework defaults to three decorators (uptime, level, tags) whenever the user does not specify otherwise through -Xlog. However, some specific logging cases do not need decorations, and manually having to disable them results in cumbersome extra input and loss of ergonomics. For example, C2 developers rarely need decorations, and having to manually specify this every time results inconvenient.
>
> To address this, this PR enables the possibility of adding tag-specific disabling of default decorators to UL. These disables are in no way overriding user input -- they will only act whenever -Xlog has no decorators supplied and there is a positive match with the pre-specified defaults. Such a match is based on an inclusion rule: e.g. if -Xlog:jit+compilation is provided, a default for jit may be applied. Additionally, defaults may target a specific log level.
>
> The original use case for this is related to C2 logging migration to UnifiedLogging, as currently no decorators are found in compiler logs and it would be expected to stay the same without the extra explicit removal every time via -Xlog. However, this would ease the migration of other logging that was initially deterred by this, such as -XX:+PrintInterpreter.
>
> This PR is a simplification of the [8340363](https://bugs.openjdk.org/browse/JDK-8340363) (closed) ticket.
This pull request has now been integrated.
Changeset: 9bdface1
Author: Antón Seoane Ampudia <anton.seoane.ampudia at oracle.com>
Committer: Johan Sjölen <jsjolen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/9bdface14719d53f40a6572f1c3d4b816c32438b
Stats: 301 lines in 9 files changed: 287 ins; 2 del; 12 mod
8341622: Tag-specific disabled default decorators for UnifiedLogging
Reviewed-by: jsjolen, rcastanedalo, aboldtch
-------------
PR: https://git.openjdk.org/jdk/pull/21383
More information about the hotspot-compiler-dev
mailing list