RFR: 8335392: C2 MergeStores: enhanced pointer parsing
Emanuel Peter
epeter at openjdk.org
Thu Oct 17 11:48:44 UTC 2024
**Background**
I am introducing the `MemPointer`, for enhanced pointer parsing. For now, it replaces the much more limited `ArrayPointer` in `MergeStores` (see https://github.com/openjdk/jdk/pull/16245), but eventually it is supposed to be used widely in optimizations for pointer analysis: adjacency, aliasing, etc. I also plan to refactor the `VPointer` from auto-vectorization with it, and unlock more pointer patterns that way - possibly including scatter/gather.
**Details**
The `MemPointer` decomposes a pointer into the form `pointer = con + sum_i(scale_i * variable_i)` - a linear form with a sum of variables and scale-coefficients, plus some constant offset.
This form allows us to perform aliasing checks - basically we can check if two pointers are always at a constant offset. This allows us to answer many questions, including if two pointers are adjacent. `MergeStores` needs to know if two stores are adjacent, so that we can safely merge them.
More details can be found in the description in `mempointer.hpp`. Please read them when reviewing!
`MemPointer` is more powerful than the previous `ArrayPointer`: the latter only allows arrays, the former also allows native memory accesses, `Unsafe` and `MemorySegement`.
**Dealing with Overflows**
We have to be very careful with overflows when dealing with pointers. For this, I introduced a `NoOverflowInt`. It allows us to do "normal" int operations on it, and tracks if there was ever an overflow. This way, we can do all overflow checks implicitly, and do not clutter the code with overflow-checks or - God forbid - forget overflow-checks.
-------------
Commit messages:
- Merge branch 'master' into JDK-8335392-MemPointer
- Merge branch 'master' into JDK-8335392-MemPointer
- fix build and test
- add precompiled.hpp to gtest
- finishing up more proofs
- rm scaleL, was not even necessary!
- more proof
- improve the proof
- move proof to hpp
- first part of the proof
- ... and 66 more: https://git.openjdk.org/jdk/compare/1ea1f33f...3c333baf
Changes: https://git.openjdk.org/jdk/pull/19970/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19970&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8335392
Stats: 2421 lines in 15 files changed: 2160 ins; 212 del; 49 mod
Patch: https://git.openjdk.org/jdk/pull/19970.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19970/head:pull/19970
PR: https://git.openjdk.org/jdk/pull/19970
More information about the hotspot-compiler-dev
mailing list