RFR: 8341068: [s390x] intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v2]

[Amit Kumar]

On Thu, 17 Oct 2024 12:53:47 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 6258:
>> 
>>> 6256: // Unsigned Integer Register Division
>>> 6257: // NOTE: z_dlr requires even-odd pair. remainder will be in even register(r4) & quotient will be stored in odd register(r5)
>>> 6258: // for dividend, leftmost 32bits will be in r4 and rightmost 32bits will be in r5 register.
>> 
>> Suggestion:
>> 
>> // for dividend, upper 32bits will be in r4 and lower 32bits will be in r5 register.
>> 
>> 
>> This PR uses the terms "leftmost" and "rightmost" for numerically higher and lower parts of an integer. I wondered if this perhaps was common in s390.ad, but it is not. Please say "higher" and "lower".
>
> Or even "low" and "high".

I followed the PofZ book and took "leftmost" and "rightmost" from it. But now I have updated it to "upper" and "lower" that feels more intuitive.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21559#discussion_r1804749927