RFR: 8339067: Convert Threshold flags (like Tier4MinInvocationThreshold and Tier3MinInvocationThreshold) to double [v2]
Amit Kumar
amitkumar at openjdk.org
Fri Oct 18 03:49:25 UTC 2024
On Tue, 15 Oct 2024 19:49:40 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/share/opto/bytecodeInfo.cpp line 316:
>>
>>> 314: int call_site_count = caller_method->scale_count(profile.count());
>>> 315: int invoke_count = caller_method->interpreter_invocation_count();
>>> 316: assert(invoke_count >= 0, "require invocation count greater than zero");
>>
>> Technically, the comment is now wrong. It is no longer "greater than" but "greater than or equal to zero". Is that intended? Otherwise you should use `>`.
>
> Actually it should be `>` because we divide by it in next line.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21354#discussion_r1805804832
More information about the hotspot-compiler-dev
mailing list