RFR: 8338126 : C2 SuperWord: VectorCastF2HF / vcvtps2ph produces wrong results for vector length 2 [v4]

Tobias Hartmann thartmann at openjdk.org
Fri Oct 18 06:58:10 UTC 2024


On Wed, 16 Oct 2024 16:28:50 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> When Float.floatToFloat16 is vectorized using a 2-element vector width due to dependencies, we incorrectly generate a 4-element vcvtps2ph with memory as destination storing 8 bytes instead of desired 4 bytes.  This issue is fixed in this PR by limiting the memory version of match rule to 4-element vector and above.
>> Also a regression test case is added accordingly.
>> 
>> Best Regards,
>> Sandhya
>
> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments resolution

Marked as reviewed by thartmann (Reviewer).

Sorry for the delay. I re-submitted testing with the latest version and it all passed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21480#pullrequestreview-2377166421
PR Comment: https://git.openjdk.org/jdk/pull/21480#issuecomment-2421582354


More information about the hotspot-compiler-dev mailing list