RFR: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR

[Lutz Schmidt]

On Thu, 17 Oct 2024 06:38:57 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> Make sure LIR_Assembler::emit_unwind_handler() jumps to the slow path directly for unlocking a synchronized method if LM_MONITOR is used.
> On the fast paths assertions are added that the mode is actually handled.
> 
> Testing: Tier1 test for fastdebug vm showed no regression.

LGTM.

Done.

From: Amit Kumar ***@***.***>
Date: Friday, 18. October 2024 at 06:00
To: openjdk/jdk ***@***.***>
Cc: Schmidt, Lutz ***@***.***>, Mention ***@***.***>
Subject: Re: [openjdk/jdk] 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR (PR #21557)

@RealLucy<https://github.com/RealLucy> can I get another approval for this :-)

—
Reply to this email directly, view it on GitHub<https://github.com/openjdk/jdk/pull/21557#issuecomment-2421285274>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ6PCMNVEBX4Q2UZYEYC2XDZ4CBT3AVCNFSM6AAAAABQC74PFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRRGI4DKMRXGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21557#pullrequestreview-2377206159
PR Comment: https://git.openjdk.org/jdk/pull/21557#issuecomment-2421623119