RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v3]

Emanuel Peter epeter at openjdk.org
Fri Oct 18 10:08:14 UTC 2024


On Fri, 18 Oct 2024 09:50:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> **Background**
>> I am introducing the `MemPointer`, for enhanced pointer parsing. For now, it replaces the much more limited `ArrayPointer` in `MergeStores` (see https://github.com/openjdk/jdk/pull/16245), but eventually it is supposed to be used widely in optimizations for pointer analysis: adjacency, aliasing, etc. I also plan to refactor the `VPointer` from auto-vectorization with it, and unlock more pointer patterns that way - possibly including scatter/gather.
>> 
>> **Details**
>> 
>> The `MemPointer` decomposes a pointer into the form `pointer = con + sum_i(scale_i * variable_i)` - a linear form with a sum of variables and scale-coefficients, plus some constant offset.
>> 
>> This form allows us to perform aliasing checks - basically we can check if two pointers are always at a constant offset. This allows us to answer many questions, including if two pointers are adjacent. `MergeStores` needs to know if two stores are adjacent, so that we can safely merge them.
>> 
>> More details can be found in the description in `mempointer.hpp`. Please read them when reviewing!
>> 
>> `MemPointer` is more powerful than the previous `ArrayPointer`: the latter only allows arrays, the former also allows native memory accesses, `Unsafe` and `MemorySegement`.
>> 
>> **Dealing with Overflows**
>> 
>> We have to be very careful with overflows when dealing with pointers. For this, I introduced a `NoOverflowInt`. It allows us to do "normal" int operations on it, and tracks if there was ever an overflow. This way, we can do all overflow checks implicitly, and do not clutter the code with overflow-checks or - God forbid - forget overflow-checks.
>> 
>> **Benchmarks**
>> 
>> I added a few new benchmarks, to show the merging of `Unsafe` and `native` stores. We an see that 8 byte stores are now merged, and have the same performance as a long store. The same for 4 char stores that are merged into a single long store.
>> 
>> ![image](https://github.com/user-attachments/assets/33b5cfcb-919b-46f4-bfa8-69fdff3acf1a)
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some unsafe and native benchmarks added

I added this section to the desctiption above.

**Benchmarks**

I added a few new benchmarks, to show the merging of `Unsafe` and `native` stores. We an see that 8 byte stores are now merged, and have the same performance as a long store. The same for 4 char stores that are merged into a single long store.

![image](https://github.com/user-attachments/assets/33b5cfcb-919b-46f4-bfa8-69fdff3acf1a)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19970#issuecomment-2422067951


More information about the hotspot-compiler-dev mailing list