RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v25]
Paul Sandoz
psandoz at openjdk.org
Fri Oct 18 16:55:05 UTC 2024
On Thu, 17 Oct 2024 23:35:36 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> > I have restricted the IR validation to just newly added UMin/UMax transformations.
>
> Even then i think it better to do so in follow on PR, otherwise it is a moving target for review and testing. This new test fails on aarch64 e.g.,
>
> ```
> STATUS:Failed.`main' threw exception: compiler.lib.ir_framework.shared.TestFormatException: Violations (16) --------------- - Could not find VM flag "UseAVX" in @IR rule 1 at public void compiler.vectorapi.VectorUnsignedMinMaxIRTransformsTest.umin_ir_transform1_byte()
> ...
> ```
>
> Testing tier 1 to 3 with latest PR looks good otherwise.
The updated test passes with latest changes. You will need a HotSpot re-review including the new test.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2422875427
More information about the hotspot-compiler-dev
mailing list