RFR: 8342601: AArch64: Micro-optimize bit shift in copy_memory
Aleksey Shipilev
shade at openjdk.org
Mon Oct 21 08:09:53 UTC 2024
On Fri, 18 Oct 2024 18:35:02 GMT, Chad Rakoczy <duke at openjdk.org> wrote:
> [JDK-8342601](https://bugs.openjdk.org/browse/JDK-8342601)
>
> Fix minor inefficiency in `copy_memory` by adding check before doing bit shift to see if we are able to do a move instruction instead. Change is low risk because of the low complexity of the change
>
> Ran array copy and tier 1 on aarch64 machine
>
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR
> jtreg:test/hotspot/jtreg/compiler/arraycopy 49 49 0 0
> ==============================
>
> ==============================
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR
> jtreg:test/hotspot/jtreg:tier1 2591 2591 0 0
> jtreg:test/jdk:tier1 2436 2436 0 0
> jtreg:test/langtools:tier1 4577 4577 0 0
> jtreg:test/jaxp:tier1 0 0 0 0
> jtreg:test/lib-test:tier1 34 34 0 0
> ==============================
There is `if (shift) __ lsr(...)` above at line 1376, please fix it as `shift > 0` as well.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21589#pullrequestreview-2381250288
More information about the hotspot-compiler-dev
mailing list