RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v5]

[Emanuel Peter]

On Mon, 21 Oct 2024 20:57:31 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rm dead assert
>
> src/hotspot/share/opto/noOverflowInt.hpp line 45:
> 
>> 43:   explicit NoOverflowInt(jlong value) : _is_NaN(true), _value(0) {
>> 44:     jint trunc = (jint)value;
>> 45:     if ((jlong)trunc == value) {
> 
> Do you think we need these runtime checks even in product builds?  If not, then consider using checked_cast<>() here.

I definitely need these checks in product, yes. I want longs outside the int-range to become NaN.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1810052025