RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v5]

Emanuel Peter epeter at openjdk.org
Tue Oct 22 07:09:24 UTC 2024


On Mon, 21 Oct 2024 21:14:07 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rm dead assert
>
> src/hotspot/share/opto/noOverflowInt.hpp line 90:
> 
>> 88: 
>> 89:   NoOverflowInt abs() const {
>> 90:     if (is_NaN()) { return make_NaN(); }
> 
> Suggestion:
> 
>     if (is_NaN() || value() == min_jint) { return make_NaN(); }

It is not necessary, and I actually test that in my gtest. The subtraction below handles the `min_jint` case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1810069838


More information about the hotspot-compiler-dev mailing list