RFR: 8340141: C1: rework ciMethod::equals following 8338471 [v8]
Dean Long
dlong at openjdk.org
Wed Oct 23 22:08:21 UTC 2024
> This PR changes ciMethod::equals() to a special-purpose debug helper method for the one place in C1 that uses it in an assert. The reason why making it general purpose is difficult is because JVMTI can add and delete methods. See the bug report and JDK-8338471 for more details. I'm open to suggestions for a better name than equals_ignore_version().
>
> An alternative approach, which I think may actually be better, would be to check for old methods first, and bail out if we see any. Then we can change the assert back to how it was originally, using ==.
Dean Long has updated the pull request incrementally with two additional commits since the last revision:
- add missing bailout checks
- C1 fix
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21148/files
- new: https://git.openjdk.org/jdk/pull/21148/files/80024872..fb3308c9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21148&range=07
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21148&range=06-07
Stats: 42 lines in 8 files changed: 32 ins; 0 del; 10 mod
Patch: https://git.openjdk.org/jdk/pull/21148.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21148/head:pull/21148
PR: https://git.openjdk.org/jdk/pull/21148
More information about the hotspot-compiler-dev
mailing list