RFR: 8342884: RISC-V: verify float <--> float16 conversion [v2]
Hamlin Li
mli at openjdk.org
Thu Oct 24 09:12:52 UTC 2024
On Thu, 24 Oct 2024 00:11:21 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Nit: Better to move it out of the `EXPERIMENTAL` group. Maybe immediately after the line for `UseZfh`.
>
Currently the pattern is ordering by name, so I'd prefer to keep it. :)
> (Seems we should also auto-enable this feature through hwprobe like other non-experimental flags. I see macros `RISCV_HWPROBE_EXT_ZVFH` and `RISCV_HWPROBE_EXT_ZVFHMIN` in file os_cpu/linux_riscv/riscv_hwprobe.cpp, but neither of them are checked in function `RiscvHwprobe::add_features_from_query_result`)
Thanks, add test of RISCV_HWPROBE_EXT_ZVFH, but not RISCV_HWPROBE_EXT_ZVFHMIN, as we don't have the corresponding define and usage ext_Zvfhmin and so on.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21664#discussion_r1814592635
More information about the hotspot-compiler-dev
mailing list