RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v31]

Emanuel Peter epeter at openjdk.org
Thu Oct 24 13:44:28 UTC 2024


On Thu, 24 Oct 2024 13:30:25 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> test/jdk/jdk/incubator/vector/VectorMathTest.java line 70:
>> 
>>> 68:     public static short[] INPUT_SS = {Short.MIN_VALUE,   (short)(Short.MIN_VALUE + TEN_S), ZERO_S, (short)(Short.MAX_VALUE - TEN_S), Short.MAX_VALUE};
>>> 69:     public static int[]   INPUT_SI = {Integer.MIN_VALUE, (Integer.MIN_VALUE + TEN_I),      ZERO_I, Integer.MAX_VALUE - TEN_I,        Integer.MAX_VALUE};
>>> 70:     public static long[]  INPUT_SL = {Long.MIN_VALUE,    Long.MIN_VALUE + TEN_L,           ZERO_L, Long.MAX_VALUE - TEN_L,           Long.MAX_VALUE};
>> 
>> Ok, now we have 4 or 5 hand-crafted examples. Is that sufficient? Some random values would be nice, then we know that at least eventually we have full coverage.
>
> Hand crafter cases contains delimiting and general cases, in short they sufficiently cover entire value range.

@PaulSandoz do you think this is sufficient coverage?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1815012386


More information about the hotspot-compiler-dev mailing list