RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v32]

Jatin Bhateja jbhateja at openjdk.org
Thu Oct 24 14:03:26 UTC 2024


On Thu, 24 Oct 2024 13:36:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 37 commits:
>> 
>>  - Review resolutions.
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201
>>  - Factor out IR tests and Transforms to follow-up PRs.
>>  - Replacing flag based checks with CPU feature checks in IR validation test.
>>  - Remove Saturating IRNode patterns.
>>  - Restrict IR validation to newly added UMin/UMax transforms.
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201
>>  - Prod build fix
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338201
>>  - New IR tests + additional IR transformations
>>  - ... and 27 more: https://git.openjdk.org/jdk/compare/158b93d1...0e10139c
>
> src/hotspot/cpu/x86/x86.ad line 10593:
> 
>> 10591:   match(Set dst (SaturatingAddV src1 src2));
>> 10592:   match(Set dst (SaturatingSubV src1 src2));
>> 10593:   format %{ "vector_addsub_saturating_subword $dst, $src1, $src2" %}
> 
> Could the `Opcode` be put into the `format` string? Not strictly necessary, but would be neat.

Desirable future extension, but its not related to this specific PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1815050398


More information about the hotspot-compiler-dev mailing list