RFR: 8342975: C2: Micro-optimize PhaseIdealLoop::Dominators()

Vladimir Kozlov kvn at openjdk.org
Thu Oct 24 19:12:05 UTC 2024


On Thu, 24 Oct 2024 17:10:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Noticed this while looking at Leyden profiles. C2 seems to spend considerable time doing in this loop. The disassembly shows this loop is fairly hot. Replacing the initialization with memset, while touching more memory, is apparently faster. memset is also what we normally do around C2 for arena-allocated data. We seem to touch a lot of these structs later on, so pulling them to cache with memset is likely "free". 
> 
> It also looks like current initialization misses initializing the last element (at `C->unique()+1`).
> 
> I'll put performance data in separate comment.

Nice find.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21690#pullrequestreview-2393510365


More information about the hotspot-compiler-dev mailing list