RFR: 8342962: [s390x] TestOSRLotsOfLocals.java crashes [v2]

[Lutz Schmidt]

On Fri, 25 Oct 2024 08:31:43 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> We are on thin ice with the `TestOSRLotsOfLocals` test. Before it breaks, I'd like to provide the fix. :-)
>> 
>> Testing : Tier1 test with fastdebug vm.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments from Lutz

Looks good now.
Yet another idea, though.

src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp line 139:

> 137:     const int locals_space = BytesPerWord * method() -> max_locals();
> 138:     int monitor_offset = locals_space + (2 * BytesPerWord) * (number_of_locks - 1);
> 139:     bool handled_manually = false;

Sorry, another idea (no need to accept it):

  bool large_offset = ! Immediate::is_simm20(monitor_offset + BytesPerWord) && number_of_locks > 0;

  if (large_offset) {
. . .

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21703#pullrequestreview-2395364719
PR Review Comment: https://git.openjdk.org/jdk/pull/21703#discussion_r1816728916