RFR: 8343070: Enable is_trace_align_vector when TraceSuperWord is set
Hamlin Li
mli at openjdk.org
Mon Oct 28 10:05:32 UTC 2024
On Mon, 28 Oct 2024 07:08:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Hi,
>> Can you help to review this simple patch?
>> Currently, in SuperWord::filter_packs_for_alignment(), there is some log not turned on when TraceSuperWord is set, but I think it should, as it's more convenient for users to debug.
>> Thanks!
>
> Ah, one more thing. I try to keep `SW_INFO` and `TraceSuperWord` in sync. So if we do decide to add `ALIGN_VECTOR` to `TraceSuperWord`, we should also add it to `SW_INFO`.
> Looks reasonable to me but @eme64 should have a look at this as well.
>
> /reviewers 2
Thanks @TobiHartmann !
Thanks @eme64 for discussion! :)
I'm on vacation, will get back to you when I'm back later.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21715#issuecomment-2441121074
PR Comment: https://git.openjdk.org/jdk/pull/21715#issuecomment-2441123459
More information about the hotspot-compiler-dev
mailing list