RFR: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor [v2]

Emanuel Peter epeter at openjdk.org
Mon Oct 28 10:28:25 UTC 2024


On Mon, 28 Oct 2024 10:11:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small update
>
> src/hotspot/share/opto/predicates.hpp line 952:
> 
>> 950:   Node* _new_control;
>> 951:   PhaseIdealLoop* const _phase;
>> 952:   ParsePredicateSuccessProj* _current_parse_predicate;
> 
> It looks to me like this could be a boolean, correct?

Then the name could also be more descriptive

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21679#discussion_r1818769211


More information about the hotspot-compiler-dev mailing list