RFR: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor [v2]

[Christian Hagedorn]

On Mon, 28 Oct 2024 10:06:33 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small update
>
> src/hotspot/share/opto/predicates.hpp line 946:
> 
>> 944: // Visitor to create Initialized Assertion Predicates at a target loop from Template Assertion Predicates from a source
>> 945: // loop. This visitor can be used in combination with a PredicateIterator.
>> 946: class AssertionPredicatesForLoop : public PredicateVisitor {
> 
> I think this could have a more expressive name. It is a Visitor... hmm
> Maybe `InitializedAssertionPredicatesFromTemplatesCreator`? Hmm not sure.
> 
> The current name suggests that it is just a collection of `AssertionPredicates`.

As discussed offline, maybe `CreateAssertionPredicatesVisitor`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21679#discussion_r1818802276