RFR: 8331861: [PPC64] Implement load / store assembler functions which take an Address object

Varada M varadam at openjdk.org
Mon Oct 28 16:40:21 UTC 2024


On Thu, 24 Oct 2024 10:41:27 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Load and store assembly instructions which takes Address object as argument. 
>> 
>> Tier 1 testing successful on linux-ppc64le and aix-ppc (fastdebug level)
>> 
>> JBS : [JDK-8331861](https://bugs.openjdk.org/browse/JDK-8331861)
>
> src/hotspot/cpu/ppc/assembler_ppc.hpp line 2534:
> 
>> 2532:   void stw( Register d, Address &a, Register tmp = noreg);
>> 2533:   void sth( Register d, Address &a, Register tmp = noreg);
>> 2534:   void stb( Register d, Address &a, Register tmp = noreg);
> 
> Spaces before "Register d" are uncommon. Please remove them (you can keep the one for ld to align it with the other ones).

Thank you Martin. I have fixed the alignment for both the cases (RegisterOrConstant and Address obj). Also I have adapted the same changes to load instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21492#discussion_r1816047123


More information about the hotspot-compiler-dev mailing list