RFR: 8342156: C2: Compilation failure with fewer arguments after JDK-8329032 [v3]

Vladimir Kozlov kvn at openjdk.org
Tue Oct 29 16:14:10 UTC 2024


On Tue, 29 Oct 2024 10:42:26 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> Adding C2 register allocation support for APX EGPRs ([JDK-8329032](https://bugs.openjdk.org/browse/JDK-8329032)) reduced, due to unfortunate rounding in the register mask size computation, the available space for incoming/outgoing method arguments in register masks.
>> 
>> ### Changeset
>> 
>> - Bump the number of 32-bit words dedicated to incoming/outgoing arguments in register masks from 3 to 4.
>> - Add a regression test.
>> 
>> ### Testing
>> 
>> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/11436050131)
>> - `tier1` to `tier4` (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.
>> - C2 compilation time benchmarking for DaCapo on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64. There is no observable difference in C2 compilation time.
>
> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update mask size comment after suggestions

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21612#pullrequestreview-2402445104


More information about the hotspot-compiler-dev mailing list