RFR: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'

[Vladimir Kozlov]

On Tue, 29 Oct 2024 16:59:12 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> On linux-x64 gcc generate compile error: `src/hotspot/cpu/x86/assembler_x86.cpp:3646:6: error: redefinition of 'void Assembler::evmovdquw(XMMRegister, KRegister, XMMRegister, bool, int)'` after [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) and [JDK-8338021](https://bugs.openjdk.org/browse/JDK-8338021).
> The both PRs add the same C++ function implementation `void Assembler::evmovdquw(XMMRegister, KRegister, XMMRegister, bool, int)`.
> I think the newly added functions can be merged to one.
> I choose to delete the implementation added by [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527). And I verify the releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527), after this PR the releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) run passed.
> 
> Additonal testing:
> 
> - [x] linux x64 build with release/fastdebug/slowdebug configure
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux x64 with release build
> 
> The releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) shows below:
> 
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512Intrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512MultiBlockIntrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5MultiBlockIntrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3Intrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3MultiBlockIntrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java
> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5Intrinsics.java

So we had declaration in .hpp file for long time but not implementation?

@jatin-bhateja which version should be chosen?

test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java line 2:

> 1: /*
> 2:  * Copyright (c) 2014, 2024, Oracle and/or its affiliates. All rights reserved.

Did we miss this year update in previous PRs?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21768#pullrequestreview-2402675206
PR Comment: https://git.openjdk.org/jdk/pull/21768#issuecomment-2444936070
PR Review Comment: https://git.openjdk.org/jdk/pull/21768#discussion_r1821282163