RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v7]

Tue Oct 29 18:29:07 UTC 2024

On Tue, 29 Oct 2024 13:57:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 82 commits:
>> 
>>  - manual merge with master
>>  - changes to NoOverflowInt for Dean
>>  - rm dead assert
>>  - updates for Vladimir
>>  - some unsafe and native benchmarks added
>>  - more examples and comments for Vladimir
>>  - Merge branch 'master' into JDK-8335392-MemPointer
>>  - Merge branch 'master' into JDK-8335392-MemPointer
>>  - fix build and test
>>  - add precompiled.hpp to gtest
>>  - ... and 72 more: https://git.openjdk.org/jdk/compare/d8b3685d...8f58e889
>
> Nice work! I have a first round of comments - mostly minor things. So far, it looks good. Will pick this up again tomorrow.

@chhagedorn thanks for all your comments. I addressed all now.
I had to fix that one assert in `MemPointerAliasing` constructor - it was wrong and I added regression tests for it now 😊 

Looking forward to the next part of your review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19970#issuecomment-2445034722