RFR: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'

[David Holmes]

On Tue, 29 Oct 2024 17:32:06 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> On linux-x64 gcc generate compile error: `src/hotspot/cpu/x86/assembler_x86.cpp:3646:6: error: redefinition of 'void Assembler::evmovdquw(XMMRegister, KRegister, XMMRegister, bool, int)'` after [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) and [JDK-8338021](https://bugs.openjdk.org/browse/JDK-8338021).
>> The both PRs add the same C++ function implementation `void Assembler::evmovdquw(XMMRegister, KRegister, XMMRegister, bool, int)`.
>> I think the newly added functions can be merged to one.
>> I choose to delete the implementation added by [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527). And I verify the releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527), after this PR the releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) run passed.
>> 
>> Additonal testing:
>> 
>> - [x] linux x64 build with release/fastdebug/slowdebug configure
>> - [ ] jtreg tests(include tier1/2/3 etc.) on linux x64 with release build
>> 
>> The releated tests of [JDK-8341527](https://bugs.openjdk.org/browse/JDK-8341527) shows below:
>> 
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512Intrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512MultiBlockIntrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5MultiBlockIntrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3Intrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3MultiBlockIntrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java
>> test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5Intrinsics.java
>
> Thanks all for the review.

Thanks @sendaoYan

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21768#issuecomment-2445501296