RFR: 8343296: IGV: Show pre/main/post at CountedLoopNodes

[Roberto Castañeda Lozano]

On Wed, 30 Oct 2024 13:36:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> It's sometimes difficult to keep track of which counted loops are pre, main or post loops. This patch adds this property to `CountedLoops`, similarly to the other node info that we print, for example, like a method name for a `CallStaticJava`.
> 
> This is achieved by emitting a new property to `CountedLoopNodes` and then extending the node info filter in IGV. This will show the pre/main/post info like the other node info below the node name:
> 
> ![image](https://github.com/user-attachments/assets/69abe3f4-3e97-4dfe-983a-0153057b1a8d)
> 
> Thanks to @robcasloz for helping me with the IGV filter changes!
> 
> Thanks,
> Christian

Looks good otherwise, thanks for doing this Christian!

src/utils/IdealGraphVisualizer/ServerCompiler/src/main/resources/com/sun/hotspot/igv/servercompiler/filters/customNodeInfo.filter line 37:

> 35: editProperty(hasProperty("loop_kind"), ["loop_kind"], "extra_label",
> 36:              function(loop_kind) { return loop_kind[0]; });
> 37: 

Can you remove this extra line at the end?

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21788#pullrequestreview-2405230412
PR Review Comment: https://git.openjdk.org/jdk/pull/21788#discussion_r1822817709