RFR: 8343296: IGV: Show pre/main/post at CountedLoopNodes [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed Oct 30 17:56:05 UTC 2024


On Wed, 30 Oct 2024 15:38:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> It's sometimes difficult to keep track of which counted loops are pre, main or post loops. This patch adds this property to `CountedLoops`, similarly to the other node info that we print, for example, like a method name for a `CallStaticJava`.
>> 
>> This is achieved by emitting a new property to `CountedLoopNodes` and then extending the node info filter in IGV. This will show the pre/main/post info like the other node info below the node name:
>> 
>> ![image](https://github.com/user-attachments/assets/69abe3f4-3e97-4dfe-983a-0153057b1a8d)
>> 
>> Thanks to @robcasloz for helping me with the IGV filter changes!
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - add new line
>  - remove empty line

Marked as reviewed by rcastanedalo (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21788#pullrequestreview-2405807752


More information about the hotspot-compiler-dev mailing list