RFR: 8343296: IGV: Show pre/main/post at CountedLoopNodes [v2]
Vladimir Kozlov
kvn at openjdk.org
Wed Oct 30 18:46:12 UTC 2024
On Wed, 30 Oct 2024 15:38:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> It's sometimes difficult to keep track of which counted loops are pre, main or post loops. This patch adds this property to `CountedLoops`, similarly to the other node info that we print, for example, like a method name for a `CallStaticJava`.
>>
>> This is achieved by emitting a new property to `CountedLoopNodes` and then extending the node info filter in IGV. This will show the pre/main/post info like the other node info below the node name:
>>
>> 
>>
>> Thanks to @robcasloz for helping me with the IGV filter changes!
>>
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>
> - add new line
> - remove empty line
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21788#pullrequestreview-2405965883
More information about the hotspot-compiler-dev
mailing list