RFR: 8343122: RISC-V: C2: Small improvement for real runtime callouts

Robbin Ehn rehn at openjdk.org
Thu Oct 31 07:36:27 UTC 2024


On Mon, 28 Oct 2024 04:39:17 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, please review this small improvement.
> 
> Currently, we do 11 instructions for real C2 runtime callouts (See riscv_enc_java_to_runtime).
> Seems we can materialize the pointer faster with `movptr2`, which will reduce 2 instructions.
> But we will need to reorder the original calling sequence a bit to make `t0` available for `movptr2`.
> 
> Testing on linux-riscv64 platform:
> - [x] tier1-tier3 (release)
> - [x] hotspot:tier1 (fastdebug)

Nice!

But I don't see the code change for this comment change:

-  //   sd(t1, Address(sp, wordSize))  ->  sd
+  //   sd(t0, Address(sp, wordSize))  ->  sd

What am I missing ?

EDIT: Sorry ignore above, early morning...

Marked as reviewed by rehn (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21733#pullrequestreview-2407190032
PR Review: https://git.openjdk.org/jdk/pull/21733#pullrequestreview-2407200564


More information about the hotspot-compiler-dev mailing list