RFR: 8341781: Improve Min/Max node identities [v2]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Thu Oct 31 14:15:29 UTC 2024


On Thu, 31 Oct 2024 08:57:28 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> From my understanding this isn't possible as-is since CPU features seem to be checked regardless of whether the architecture supports it or not, so we can't simply check for AVX because that would fail on aarch64 and riscv64. I think we could work around this with `applyIfCPUFeatureOr = {"avx", "true", "asimd", "true", "rvv", "true"}` to force a check for all 3 platforms but it'd be filtering more platforms than strictly necessary.
>
> Which platforms would be filtered "more platforms than strictly necessary"?

With the workaround to check for CPU features on all 3 platforms, we'd be not checking the IR when `asimd = false` or `rvv = false`, but the IR check should pass with those features too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21439#discussion_r1824549814


More information about the hotspot-compiler-dev mailing list