RFR: 8341781: Improve Min/Max node identities [v2]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Thu Oct 31 16:53:58 UTC 2024
On Thu, 31 Oct 2024 15:37:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> First: yes, I'm fine with just using CPU features - it will IR test it on fewer platforms than maybe desired, but that is ok, I think.
>>
>> I guess the issue with `@IR` is that it only allows `AND` or `OR` clauses ... and not the more complicated mix of `&` and `|` from `@requires`. But in theory, you can just have multiple `@IR` rules (that simulates the OR):
>> - One for `x64` (applyIfPlatform) and `avx` (applyIfCPUFeature)
>> - One IR rule for each of: `aarch64` and `riscv64` (applyIfPlatform)
>>
>> But again, I'm ok with only checking for CPU features... it is more simple.
>
> @chhagedorn you may be interested in this conversation as well ;)
I hadn't considered using multiple IR checks, that would definitely work as well. I've pushed a commit that just uses the CPU features, to keep it simple. Let me know what you think!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21439#discussion_r1824820822
More information about the hotspot-compiler-dev
mailing list