RFR: 8339242: Fix overflow issues in AdlArena

Johan Sjölen jsjolen at openjdk.org
Mon Sep 2 08:23:19 UTC 2024


On Sat, 31 Aug 2024 04:49:57 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> If the aim is to increase security, would it not make more sense to test against hardcoded "reasonable max" values? Anything larger than a few MB is likely to be an error anyway, or?

This is a build-time only feature, as it's run on `*.ad` files, so I think this should count as trusted input. The assertions in the PR just let's us bail early rather than discovering the overflow later on through a crash (or not at all).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20774#issuecomment-2324111151


More information about the hotspot-compiler-dev mailing list