RFR: 8339299: C1 will miss type profile when inline final method [v2]

kuaiwei duke at openjdk.org
Mon Sep 2 09:24:57 UTC 2024


On Fri, 30 Aug 2024 22:28:45 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modify test case to use whitebox api
>
> test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java line 43:
> 
>> 41: public class TypeProfileFinalMethod {
>> 42:     public static void main(String[] args) throws Exception {
>> 43:         if (args.length == 1 && args[0].equals("Run")) {
> 
> Instead of a check at runtime, you can introduce a separate class which drives test logic. Take a look at `compiler/jsr292/MHInlineTest.java` for an example (or grep for `class Launcher` under `test/hotspot/jtreg`).

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20786#discussion_r1740596957


More information about the hotspot-compiler-dev mailing list