RFR: 8339242: Fix overflow issues in AdlArena [v2]

[Casper Norrbin]

On Fri, 30 Aug 2024 23:35:41 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   arena realloc overflow check
>
> src/hotspot/share/adlc/adlArena.cpp line 154:
> 
>> 152:   if( (c_old+old_size == _hwm) &&            // Adjusting recent thing
>> 153:       ((size_t)(_max-c_old) >= new_size) ) { // Still fits where it sits, safe from overflow
>> 154: 
> 
> This code appears to be a copy of Arena::Arealloc, so we should probably fix both at the same time.

Good catch! Fixed in cf0b434.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20774#discussion_r1740625142