RFR: 8330159: [C2] Remove or clarify Compile::init_start [v5]

[Yagmur Eren]

On Mon, 2 Sep 2024 11:10:35 GMT, Yagmur Eren <duke at openjdk.org> wrote:

>> Compile::init_start method contained only an assertion. To cleanup, this method is removed and the locations where this method is called are replaced with the corresponding assertion. See issue: [JDK-8330159](https://bugs.openjdk.org/browse/JDK-8330159)
>
> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding NOT_DEBUG_RETURN instead of DEBUG_ONLY for Compile::verify_start

Thanks a lot for the review and suggestions @dean-long and @chhagedorn! I believe I can integrate now if it looks good!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20715#issuecomment-2324469670