RFR: JDK-8332423 : [PPC64] Remove C1_MacroAssembler::call_c_with_frame_resize [v6]

[Martin Doerr]

On Thu, 29 Aug 2024 07:49:49 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8332423](https://bugs.openjdk.org/browse/JDK-8332423)
>> C1_MacroAssembler::call_c_with_frame_resize is only used with frame_resize == 0. 
>> Also, call_c is adapted as per endianess of system. 
>> We can adapt the exisiting code to handle the endianness check at one place and not have to repeatedly check at multiple places to make calls to call_c.
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - header file change
>  - remove frame_resize

Changes requested by mdoerr (Reviewer).

src/hotspot/cpu/ppc/macroAssembler_ppc.hpp line 368:

> 366:   address call_c(Register function_descriptor);
> 367:   address call_c(address function_entry, relocInfo::relocType rt = relocInfo::none) {
> 368:     return call_c((FunctionDescriptor*)function_entry, rt);

This breaks ABIv1. Please use a cast to `const FunctionDescriptor*` and move your new function below ` address call_c(const FunctionDescriptor* function_descriptor, relocInfo::relocType rt);`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19947#pullrequestreview-2276140748
PR Review Comment: https://git.openjdk.org/jdk/pull/19947#discussion_r1741239572