RFR: 8326615: C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash) [v5]
Damon Fenacci
dfenacci at openjdk.org
Tue Sep 3 09:36:21 UTC 2024
On Wed, 24 Jul 2024 19:21:58 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Damon Fenacci has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Update src/hotspot/share/gc/z/c1/zBarrierSetC1.cpp
>>
>> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>> - Update src/hotspot/share/gc/z/c1/zBarrierSetC1.cpp
>>
>> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>> - Update src/hotspot/share/gc/x/c1/xBarrierSetC1.cpp
>>
>> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> Based on that we need to scale CodeCacheMinimumUseSpace based on number of C1 compiler threads to take into account buffer size: `NMethodSizeLimit` (or more precise `Compiler::code_buffer_size()`). And may be similar for C2 even so its buffer is not permanent. Size for C2 is difficult to determine because it is calculated based on compilation information. But may be we can use the same as for C1 as rough estimation.
Thanks @vnkozlov @TobiHartmann for your reviews!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19280#issuecomment-2326055186
More information about the hotspot-compiler-dev
mailing list